Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor default event bus & drop symfony event bus #465

Merged
merged 4 commits into from
Jan 15, 2024
Merged

refactor default event bus & drop symfony event bus #465

merged 4 commits into from
Jan 15, 2024

Conversation

DavidBadura
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 124.138ms (±0.00%) | 125.686ms (±0.00%) | 32.625mb        | 32.606mb   |
| benchSave1Event ()                     | 1.063ms (±0.00%)   | 1.016ms (±0.00%)   | 32.625mb        | 32.606mb   |
| benchSave10000Events ()                | 283.274ms (±0.00%) | 274.788ms (±0.00%) | 32.851mb        | 32.830mb   |
| benchSave10000Aggregates ()            | 11.146s (±0.00%)   | 11.360s (±0.00%)   | 32.625mb        | 32.606mb   |
| benchSave10000AggregatesTransaction () | 780.133ms (±0.00%) | 780.267ms (±0.00%) | 32.625mb        | 32.606mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.412ms (±0.00%)   | 2.367ms (±0.00%)   | 36.009mb        | 35.990mb   |
| benchSave10000Events () | 319.094ms (±0.00%) | 311.301ms (±0.00%) | 36.277mb        | 36.255mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.488ms (±0.00%)   | 1.373ms (±0.00%)   | 8.122mb         | 8.109mb    |
| benchSave10000Events () | 452.614ms (±0.00%) | 447.524ms (±0.00%) | 33.453mb        | 33.440mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 124.145ms (±0.00%) | 125.412ms (±0.00%) | 32.646mb        | 32.627mb   |
| benchLoad10000Events ()                | 198.000μs (±0.00%) | 197.850μs (±0.00%) | 32.646mb        | 32.627mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Jan 11, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Jan 11, 2024
@DavidBadura DavidBadura changed the title refactor event bus & drop symfony event bus refactor default event bus & drop symfony event bus Jan 11, 2024
@DavidBadura DavidBadura force-pushed the refactor-event-bus branch 4 times, most recently from dc69d84 to 697c0bf Compare January 12, 2024 09:58
DanielBadura
DanielBadura reviewed Jan 12, 2024
View reviewed changes
src/Attribute/Subscribe.php Outdated Show resolved Hide resolved
src/EventBus/AttributeListenerProvider.php Outdated Show resolved Hide resolved
src/EventBus/ListenerDescriptor.php Outdated Show resolved Hide resolved
src/Metadata/Projector/AttributeProjectorMetadataFactory.php Outdated Show resolved Hide resolved
src/WatchServer/WatchListener.php Outdated Show resolved Hide resolved
@DavidBadura DavidBadura merged commit e1da663 into 3.0.x Jan 15, 2024
31 of 33 checks passed
@DavidBadura DavidBadura deleted the refactor-event-bus branch January 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura